Conversation
cboh4
requested review from
Cashmaney,
liorbond,
toml01 and
valdok
as code owners
cboh4
force-pushed
the
cron-module
branch
2 times, most recently
from
25b4370 to
f4b586e
Compare
…ssages that would be executed in the next round
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ctx.Logger().Error("Failed to execute cron message", "error", err) | ||
| // return err | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| for idx, msg := range execCronMsgs { | ||
| fmt.Printf("idx, msg: %+v %+v\n", idx, msg) | ||
| ctx = ctx.WithTxBytes(bytesCronMsgs[idx]) | ||
| _, err := am.keeper.Execute(ctx, msg.Contract, msg.Sender, msg.Msg, msg.SentFunds, msg.CallbackSig, wasmtypes.HandleTypeExecute) | ||
| if err != nil { | ||
| ctx.Logger().Error("Failed to execute cron message", "error", err) | ||
| // return err | ||
| } | ||
| } |
There was a problem hiding this comment.
Not sure if this correct.
Here you execute cron messages first (before block txs).
Whereas in the enclave code cron messages are appended last.
| package nullify | ||
|
|
||
| import ( | ||
| "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import Note test
|
|
||
| import ( | ||
| "reflect" | ||
| "unsafe" |
Check notice
Code scanning / CodeQL
Sensitive package import Note test
|
|
||
| import ( | ||
| context "context" | ||
| reflect "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import Note test
3 participants
No description provided.